zifeihan commented on issue #6114:
URL: https://github.com/apache/skywalking/issues/6114#issuecomment-760662854
> > > > > config server(nacos,zk) <--update Event--> OAP --command--> agent
> > > > > did I get that right?
> > > >
> > > >
> > > > Yes, but we need more details about how to make this happens. Such as
> > > >
> > > > 1. The gRPC service between agent and OAP
> > > > 2. How to define the configuration of every servic in the
configuration center. Such as, do you provide one key with a YAML as value for
all services?
> > > > 3. How the agent core and plugin declare the config is changeable,
and listening to the change event from the command.
> > >
> > >
> > >
> > > 1. define a gRPC service
> > >
> > > ```
> > > import "common/Common.proto";
> > >
> > > service AgentDynamicConfigTask {
> > >
> > > // query all sniffer need to execute dynamic config task commands
> > > rpc getDynamicConfigCommands (DynamicConfigTaskCommandQuery)
returns (Commands) {
> > > }
> > >
> > > message DynamicConfigTaskCommandQuery {
> > > // last command timestamp
> > > int64 lastCommandTime = 1;
> > > }
> > > ```
> > >
> > >
> > >
> > > 1. implement ConfigChangeWatcher called AgentConfigWatcher, if
notified, save task to AgentDynamicConfigTaskCache
> > > 2. On agent side implement DynamicConfigTaskChannelService, schedule a
thread to poll grpc service. same as
_org.apache.skywalking.apm.agent.core.profile.ProfileTaskChannelService_
> > > 3. I don‘t know whether yaml is proper way to save agent config. Do we
need to validate yaml？
> > >
> > > hope some suggestions.
> >
> >
> > So sorry, I have completed this feature, and plan to submit it in the
next two days.
>
> It doesn't matter, I will focus on this feather
Thank you, maybe you also started this work, let us improve it together, and
I will invite you to review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
