hanahmily commented on pull request #21: URL: https://github.com/apache/skywalking-swck/pull/21#issuecomment-762065177
> > Any metrics from pods with the prometheus_io_scrape label. > > I mean, from SkyWalking perspective, could we handle this? Firstly, > > Any metrics from pods with the prometheus_io_scrape label. > > I mean, from SkyWalking perspective, could we handle this? In general, yes. oap has the capacity of handling the metrics matched MAL rules while dropping unknown ones. Users could decide which pods should be scraped by attaching/removing that label. The label is from the official example of Prometheus, is well known to users. Istio Prometheus add-on also follows the same way to scrape metrics, users who are familiar with Istio Installation will not be surprised by it. While it's a little tricky to hide the label behind Fetcher, maybe we should provide a setting to override the default label key, but Fethcer's role is a helper to guide users on how to transfer Prometheus metrics into OAP. If they have some trouble with Fetcher, the OpenTelemetry operator might be an alternative. I don't intend to add more flexible features to the current Fetcher in pre-1.0 versions. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
