This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch kezhenxu94-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit 8f171dcfe80ea179ba8f505e26c00b15c24bd651 Author: Zhenxu Ke <[email protected]> AuthorDate: Tue Jan 19 12:10:58 2021 +0800 Fix bug in `parseInternalErrorCode` `responseFlags.getUnauthorizedDetails()` will return a default instance, hence `responseFlags.getUnauthorizedDetails() != null` is always true, causing following conditions never reached --- .../oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java b/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java index ba9c69d..0317d77 100644 --- a/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java +++ b/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java @@ -202,7 +202,7 @@ public class LogEntry2MetricsAdapter { return "fault_injected"; } else if (responseFlags.getRateLimited()) { return "rate_limited"; - } else if (responseFlags.getUnauthorizedDetails() != null) { + } else if (responseFlags.hasUnauthorizedDetails()) { return "unauthorized_details"; } else if (responseFlags.getRateLimitServiceError()) { return "rate_limit_service_error";
