This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git


The following commit(s) were added to refs/heads/master by this push:
     new 6893fec  Fix bug in `parseInternalErrorCode` where some error codes 
are never reached (#6226)
6893fec is described below

commit 6893fec8bb4742da8d76a499f48034196551ebdb
Author: Zhenxu Ke <[email protected]>
AuthorDate: Tue Jan 19 16:53:06 2021 +0800

    Fix bug in `parseInternalErrorCode` where some error codes are never 
reached (#6226)
---
 CHANGES.md                                                              | 1 +
 .../oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java          | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/CHANGES.md b/CHANGES.md
index 387c7ea..fea05af 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -70,6 +70,7 @@ Release Notes.
 * Log collecting and query implementation
 * Support Alarm to feishu
 * Add the implementation of ConfigurationDiscovery on the OAP side.
+* Fix bug in `parseInternalErrorCode` where some error codes are never reached.
 
 #### UI
 * Fix un-removed tags in trace query.
diff --git 
a/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java
 
b/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java
index ba9c69d..0317d77 100644
--- 
a/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java
+++ 
b/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java
@@ -202,7 +202,7 @@ public class LogEntry2MetricsAdapter {
                 return "fault_injected";
             } else if (responseFlags.getRateLimited()) {
                 return "rate_limited";
-            } else if (responseFlags.getUnauthorizedDetails() != null) {
+            } else if (responseFlags.hasUnauthorizedDetails()) {
                 return "unauthorized_details";
             } else if (responseFlags.getRateLimitServiceError()) {
                 return "rate_limit_service_error";

Reply via email to