wu-sheng commented on a change in pull request #6232: URL: https://github.com/apache/skywalking/pull/6232#discussion_r560145005
########## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/dynamic/AgentConfigChangeWatcher.java ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.apm.agent.core.conf.dynamic; + +import lombok.AccessLevel; +import lombok.Getter; +import lombok.Setter; + +@Getter +public abstract class AgentConfigChangeWatcher { + private final String itemName; Review comment: ```suggestion // Config key, should match KEY in the Table of Agent Configuration Properties. private final String propertyKey; ``` Based on agent setup doc, this should be named as `propertyKey`, please refactor all codes(several places related). This should be a consistent concept. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
