wu-sheng commented on a change in pull request #6233:
URL: https://github.com/apache/skywalking/pull/6233#discussion_r560195455
##########
File path:
oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/parser/ConditionExpression.java
##########
@@ -50,11 +51,17 @@ public void addValue(String value) {
}
}
+ public void isNumber() {
+ number = true;
+ }
+
public void enterMultiConditionValue() {
values = new LinkedList<>();
}
public void exitMultiConditionValue() {
- value = "new Object[]{" + String.join(",", values) + "}";
+ value = number ?
+ "new double[]{" + String.join(",", values) + "}" :
Review comment:
Do you need `12D`/`12.11D`? When the number is very big.
##########
File path:
oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/parser/ConditionExpression.java
##########
@@ -50,11 +51,17 @@ public void addValue(String value) {
}
}
+ public void isNumber() {
+ number = true;
+ }
+
public void enterMultiConditionValue() {
values = new LinkedList<>();
}
public void exitMultiConditionValue() {
- value = "new Object[]{" + String.join(",", values) + "}";
+ value = number ?
+ "new double[]{" + String.join(",", values) + "}" :
Review comment:
Do you need `12D`/`12.11D`? When the number is very big.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
