wu-sheng commented on a change in pull request #6232:
URL: https://github.com/apache/skywalking/pull/6232#discussion_r560605750
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/sampling/SamplingService.java
##########
@@ -90,9 +88,9 @@ public void shutdown() {
* @return true, if sampling mechanism is on, and getDefault the sampling
factor successfully.
*/
public boolean trySampling(String operationName) {
- if (on) {
+ if (samplingRateWatcher.getSamplingRate() > 0) {
int factor = samplingFactorHolder.get();
- if (factor < Config.Agent.SAMPLE_N_PER_3_SECS) {
+ if (factor < samplingRateWatcher.getSamplingRate()) {
Review comment:
Multiple `get`(s) cause unnecessary resources. Because this get is
reading from the memory rather than CPU cache, due to the AtomicInteger.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
