kezhenxu94 commented on pull request #6232:
URL: https://github.com/apache/skywalking/pull/6232#issuecomment-764291617


   Only one problem, it's disabled by default at OAP side, while it's enabled 
at the agent side's, causing unnecessary error logs like this:
   
   ```
   ERROR 2021-01-21 12:06:11:199 
SkywalkingAgent-12-ConfigurationDiscoveryService-0 
ConfigurationDiscoveryService : ConfigurationDiscoveryService execute fail.
   org.apache.skywalking.apm.dependencies.io.grpc.StatusRuntimeException: 
UNIMPLEMENTED: Method not found: 
skywalking.v3.ConfigurationDiscoveryService/fetchConfigurations
       at 
org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:262)
       at 
org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:243)
       at 
org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:156)
       at 
org.apache.skywalking.apm.network.language.agent.v3.ConfigurationDiscoveryServiceGrpc$ConfigurationDiscoveryServiceBlockingStub.fetchConfigurations(ConfigurationDiscoveryServiceGrpc.java:211)
       at 
org.apache.skywalking.apm.agent.core.conf.dynamic.ConfigurationDiscoveryService.getAgentDynamicConfig(ConfigurationDiscoveryService.java:188)
       at 
org.apache.skywalking.apm.util.RunnableWithExceptionProtection.run(RunnableWithExceptionProtection.java:33)
       at 
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
       at 
java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305)
       at 
java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
       at 
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
       at 
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
       at java.base/java.lang.Thread.run(Thread.java:834)
   
   ERROR 2021-01-21 12:06:13:788 
SkywalkingAgent-12-ConfigurationDiscoveryService-0 
ConfigurationDiscoveryService : ConfigurationDiscoveryService execute fail.
   org.apache.skywalking.apm.dependencies.io.grpc.StatusRuntimeException: 
UNIMPLEMENTED: Method not found: 
skywalking.v3.ConfigurationDiscoveryService/fetchConfigurations
       at 
org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:262)
       at 
org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:243)
       at 
org.apache.skywalking.apm.dependencies.io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:156)
       at 
org.apache.skywalking.apm.network.language.agent.v3.ConfigurationDiscoveryServiceGrpc$ConfigurationDiscoveryServiceBlockingStub.fetchConfigurations(ConfigurationDiscoveryServiceGrpc.java:211)
       at 
org.apache.skywalking.apm.agent.core.conf.dynamic.ConfigurationDiscoveryService.getAgentDynamicConfig(ConfigurationDiscoveryService.java:188)
       at 
org.apache.skywalking.apm.util.RunnableWithExceptionProtection.run(RunnableWithExceptionProtection.java:33)
       at 
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
       at 
java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305)
       at 
java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
       at 
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
       at 
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
       at java.base/java.lang.Thread.run(Thread.java:834)
   ```
   
   You can either enable at OAP side or do some detection at the agent side 
like this
   
   
https://github.com/apache/skywalking/blob/5bfac1b50f79d544b98bfe4b20f7db165badce52/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskChannelService.java#L100-L108


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to