wu-sheng commented on a change in pull request #6243:
URL: https://github.com/apache/skywalking/pull/6243#discussion_r561860433
##########
File path:
oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/oc/OCMetricHandler.java
##########
@@ -107,6 +111,15 @@
return result;
}
+ private static Map<String, String> buildLabelsWithNodeInfo(Node node,
+ List<LabelKey>
keys,
+
List<LabelValue> values) {
+ Map<String, String> result = buildLabels(keys, values);
Review comment:
Take a look at this comment in the original proto
```
// This is required only in the first message on the stream or if the
// previous sent ExportMetricsServiceRequest message has a different Node
(e.g.
// when the same RPC is used to send Metrics from multiple Applications).
opencensus.proto.agent.common.v1.Node node = 1;
```
You need to hold the previous node, if the current `request#hasNode()` is
false, use the previous one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
