wu-sheng commented on a change in pull request #6249:
URL: https://github.com/apache/skywalking/pull/6249#discussion_r563309987
##########
File path:
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/base/StorageEsInstaller.java
##########
@@ -113,14 +115,32 @@ protected void createTable(Model model) throws
StorageException {
setting.put("index.refresh_interval", model.isRecord()
? TimeValue.timeValueSeconds(10).toString()
:
TimeValue.timeValueSeconds(config.getFlushInterval()).toString());
- setting.put("analysis.analyzer.oap_analyzer.type", "stop");
+ setting.put("analysis", getAnalyzerSetting(model.getAnalyzer()));
Review comment:
I think we should separate settings based on model's columns. Then we
don't need `combine` anymore. Also, I think it should be easier to understand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
