wu-sheng commented on a change in pull request #6249:
URL: https://github.com/apache/skywalking/pull/6249#discussion_r563474404
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/model/ModelColumn.java
##########
@@ -30,19 +31,21 @@
private final boolean matchQuery;
private final boolean storageOnly;
private final int length;
+ private final Column.AnalyzerType analyzer;
public ModelColumn(ColumnName columnName,
Class<?> type,
Type genericType,
boolean matchQuery,
boolean storageOnly,
boolean isValue,
- int length) {
+ int length, final Column.AnalyzerType analyzer) {
Review comment:
Please use a new line to follow the format. And make all parameters `as
final` or none. Don't mix the style
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
