tom-pytel commented on a change in pull request #28:
URL: https://github.com/apache/skywalking-nodejs/pull/28#discussion_r565420398
##########
File path: src/plugins/ExpressPlugin.ts
##########
@@ -95,6 +94,8 @@ class ExpressPlugin implements SwPlugin {
} catch (e) {
stopIfNotStopped(e);
throw e;
+ } finally { // req.protocol is only possibly available after call to
_handle()
+ span.tag(Tag.httpURL(((req as any).protocol ? (req as any).protocol +
'://' : '') + (req.headers.host || '') + req.url));
Review comment:
:facepalm: :facepalm: :facepalm:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
