wu-sheng commented on a change in pull request #6272:
URL: https://github.com/apache/skywalking/pull/6272#discussion_r565923216
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/ContextManagerExtendService.java
##########
@@ -84,4 +92,10 @@ public AbstractTracerContext createTraceContext(String
operationName, boolean fo
public void statusChanged(final GRPCChannelStatus status) {
this.status = status;
}
+
+ void handleIgnoreSuffixPatternsChanged() {
+ if
(StringUtil.isNotBlank(ignoreSuffixPatternsWatcher.getIgnoreSuffixPatterns())) {
+ ignoreSuffixArray =
ignoreSuffixPatternsWatcher.getIgnoreSuffixPatterns().split(",");
Review comment:
This isn't a conclusion yet, but I noticed this, 1st dynamic
configuration is sampling rate, which is an AtomicReference, so it is fine.
Then, ignore plugin, it has been approved and merged, with no `volatile`. And I
can see @zifeihan approved this too.
So, I want to ask, what do you think about this? Sometimes, no `volatile` is
tricky about when it effects in the runtime.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
