kezhenxu94 commented on pull request #116: URL: https://github.com/apache/skywalking-python/pull/116#issuecomment-769541217
> Ok, so I was uncomfortable with the idea of sending segments one by one using a streaming call so did a different way. There are now two mechanisms to prevent data loss here. > > * Added a `queue.get()` timeout so that `report()` will not block forever also setting a `collect()` timeout higher than this to make sure `report()` returns before a `collect()` timeout can possibly happen. > * Even if a timeout does happen somehow, the last segment processed is pushed back onto the queue for another attempt when the connection is reestablished (I checked that it does seem to be processed one segment at a time and not in blocks). This looks better than the previous method. Thanks ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
