gaoweijie opened a new pull request #6329:
URL: https://github.com/apache/skywalking/pull/6329


   …/skywalking/issues/6301
   
   ### Fix <bug description or the bug issue number or bug issue link>
   - [x] Verify that the fix works.
   image
   
![image](https://user-images.githubusercontent.com/8943447/107021309-ef4af600-67de-11eb-8c65-06e75e3536ff.png)
   
![image](https://user-images.githubusercontent.com/8943447/107021332-f70a9a80-67de-11eb-97fd-0838c0e59213.png)
   
   
   - [x] Explain briefly why the bug exists and how to fix it.
   these 2 parameters are the case of over-design, which makes things too 
complex. We agree, we should remove these 2 parameters, and also create span 
before method, and stop after that.
   1、remove these 2 parameters(close_before_method=true & close_ after_ 
Method), and also create span before method, and stop after that.
   2、add span isActive judgment logic.
   3、This will be better when we also upload some common info such as method 
name and request param info. The actual effect can refer to the verification 
picture provided above
   
   - [x] If this pull request closes/resolves/fixes an existing issue, replace 
the issue number. Closes #<6301>.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to