wu-sheng commented on a change in pull request #6330:
URL: https://github.com/apache/skywalking/pull/6330#discussion_r570946405



##########
File path: 
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/match/ProtectiveShieldMatcher.java
##########
@@ -44,7 +44,11 @@ public ProtectiveShieldMatcher(ElementMatcher<? super T> 
matcher) {
     @Override
     public boolean matches(T target) {
         try {
-            return this.matcher.matches(target);
+            boolean match = this.matcher.matches(target);
+            if (LOGGER.isDebugEnable()) {
+                LOGGER.debug("type={}, match={}", target, match);
+            }
+            return match;

Review comment:
       This kind of issue will exist always, but we can't add logs in every 
place, which causes logs unreadable too. This kind of issue could be located by 
agent debug easily.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to