zifeihan commented on pull request #6462:
URL: https://github.com/apache/skywalking/pull/6462#issuecomment-787013435
> ```
> private ContextSnapshot getSnapshot(CallbackCache cache) {
> ContextSnapshot snapshot = cache.getSnapshot();
> if (snapshot == null) {
> snapshot = ((CallbackCache) ((EnhancedInstance)
cache.getCallback()).getSkyWalkingDynamicField()).getSnapshot();
> }
> return snapshot;
> }
> ```
>
> In `CallbackInterceptor`'s `getSnapshot`, `((CallbackCache)
((EnhancedInstance)
cache.getCallback()).getSkyWalkingDynamicField()).getSnapshot()` requires
`CallbackCache`. So I make `CallbackAdapterInterceptor`'s
`getSkyWalkingDynamicField` returns a `CallbackCache` insteadf of
`ContextSnapshot`.
>
> Could you help me review my PR? Thanks.
> @zifeihan
yes, I think it's good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
