wu-sheng edited a comment on pull request #6467:
URL: https://github.com/apache/skywalking/pull/6467#issuecomment-787084041


   > > Hi, if there is no big grammar error in the file name, we should keep 
the old one. Because as github URL and website URL is widely used in other 
blocks, our changes could cause 404.
   > 
   > @wu-sheng Ah OK, I agree. I think it's fine to keep the file name as it 
is. Let's revert this edit?
   
   Make sense, let us keep it. And keep the old name could make reviewers more 
clear about what you changed. Otherwise, we see this, purely add a new file.
   
![image](https://user-images.githubusercontent.com/5441976/109390767-760e7100-794e-11eb-9788-12d1ec151a10.png)
   
   If we should rename a file name in the future, let's use a separated PR to 
change the file name only.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to