wu-sheng commented on pull request #33: URL: https://github.com/apache/skywalking-nodejs/pull/33#issuecomment-787950885
> > I don't think we have to. The reason other agents did this, is for propagating context. Their tracing context have to be injected in the `callback` thread to avoid trace broken. If the nodejs agent doesn't have to deal with this case, feel free to not create this local span. > > That doesn't solve the original problem I described. I am answering the question about the exit + local(callback) + exit. About your design question, in general design perspective, if one RPC framework on the top of another, then only the first exit should be created, in your question, `express` span only. One exit span means one RPC interaction between client and server, if the 2nd internal call is causing the real RPC, then it is correct to create an exit span as the child of the first exit span. The basic principle is, the exit span should be accurate mapping to the RPC behavior. Same as the entry span. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
