wu-sheng commented on a change in pull request #6477:
URL: https://github.com/apache/skywalking/pull/6477#discussion_r586084125
##########
File path: docs/en/concepts-and-designs/lal.md
##########
@@ -55,15 +54,35 @@ types of parsers at the moment, namely `json`, `yaml`, and
`text`.
When a piece of log is parsed, there is a corresponding property available,
called `parsed`, injected by LAL.
Property `parsed` is typically a map, containing all the fields parsed from
the raw logs, for example, if the parser
is `json` / `yaml`, `parsed` is a map containing all the key-values in the
`json` / `yaml`, if the parser is `text`
-, `parsed` is a map containing all the captured groups and their values (for
`regexp` and `grok`). See examples below.
+, `parsed` is a map containing all the captured groups and their values (for
`regexp` and `grok`).
+
+All parsers share the following options:
+
+| Option | Type | Description | Default Value |
+| ------ | ---- | ----------- | ------------- |
+| `abortOnFailure` | `boolean` | Whether the filter chain should abort if the
parser failed to parse / match the logs | `false` |
Review comment:
```suggestion
| `abortOnFailure` | `boolean` | Whether the filter chain should abort if
the parser failed to parse / match the logs | `true` |
```
Any reason doesn't use `true` as default?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
