wu-sheng commented on a change in pull request #6482:
URL: https://github.com/apache/skywalking/pull/6482#discussion_r587961258
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/TracingContext.java
##########
@@ -110,10 +111,13 @@
@Getter(AccessLevel.PACKAGE)
private final ExtensionContext extensionContext;
+ //CDS watcher
+ private final SpanLimitWatcher spanLimitWatcher;
+
/**
* Initialize all fields with default value.
*/
- TracingContext(String firstOPName) {
+ TracingContext(String firstOPName, SpanLimitWatcher spanLimitWatcher) {
Review comment:
If number of parameters keeps growing, we will need to add
`TracingContextConfig` as the constructor parameter, rather than keeping
adding. For now, it is fine to keep two.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
