wu-sheng commented on a change in pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#discussion_r588174198
##########
File path:
oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -376,15 +374,63 @@ public SampleFamily endpoint(List<String> serviceKeys,
List<String> endpointKeys
if (this == EMPTY) {
return EMPTY;
}
- this.context.setMeterEntity(MeterEntity.newEndpoint(dim(serviceKeys),
dim(endpointKeys)));
- return left(io.vavr.collection.Stream.concat(serviceKeys,
endpointKeys).asJava());
+ return createMeterSamples(serviceKeys, endpointKeys,
ScopeType.ENDPOINT);
+ }
+
+ private SampleFamily createMeterSamples(List<String> serviceKeys,
List<String> level2keys, ScopeType scopeType) {
Review comment:
Basically, I prefer to remove the name `level2*`. This doesn't exist in
the SkyWalking, I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
