wu-sheng commented on a change in pull request #6499:
URL: https://github.com/apache/skywalking/pull/6499#discussion_r588876768



##########
File path: 
oap-server/server-library/library-client/src/main/java/org/apache/skywalking/oap/server/library/client/elasticsearch/ElasticSearchClient.java
##########
@@ -302,8 +322,8 @@ public boolean isExistsTemplate(String indexName) throws 
IOException {
         }
     }
 
-    public boolean createTemplate(String indexName, Map<String, Object> 
settings,
-                                  Map<String, Object> mapping) throws 
IOException {
+    public boolean putTemplate(String indexName, Map<String, Object> settings,

Review comment:
       ```suggestion
       public boolean createOrUpdateTemplate(String indexName, Map<String, 
Object> settings,
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to