kezhenxu94 commented on a change in pull request #13:
URL:
https://github.com/apache/skywalking-infra-e2e/pull/13#discussion_r589018192
##########
File path: examples/simple/e2e.yaml
##########
@@ -21,18 +21,38 @@ setup:
manifests:
- path: busybox1.yaml
wait:
- - namespace: default
+ - type: kube # wait type may not only kube. it can be `log` or `http`
or else.
Review comment:
> Yes, but then in other scenarios, such as docker-compose and run, one
might use other health check mechanism. I think add `type` field in `Wait`
struct can let us reuse it in other scenarios? What do you think of it?
docker-compose has its own health check mechanism too, including `log`,
`cmd`, etc, so I'd prefer that we put the health check with their corresponding
native mechanisms so that we don't bother to create too many configurations in
NGE2E (we only check the healthiness exposed by Kubernetes / Docker compose
instead of performing the health checks ourselves), also, some of the health
checks may need to be run inside the docker containers, if we create `type`
like you do in this PR, we may create troubles for ourselves when this happens
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
