wu-sheng commented on a change in pull request #6499: URL: https://github.com/apache/skywalking/pull/6499#discussion_r591083018
########## File path: oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/base/IndexController.java ########## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.oap.server.storage.plugin.elasticsearch.base; + +import java.util.Map; +import java.util.Optional; +import java.util.concurrent.ConcurrentHashMap; +import lombok.extern.slf4j.Slf4j; +import org.apache.skywalking.apm.util.StringUtil; +import org.apache.skywalking.oap.server.core.storage.model.Model; + +/** + * The metrics data, that generated by OAL or MAL, would be partitioned to storage by the functions of the OAL or MAL. + * And, the other record data would be insulated storage by themselves definitions. + */ +@Slf4j +public enum IndexController { + INSTANCE; + + public String getTableName(Model model) { + return isAggregationModel(model) ? model.getAggregationFunctionName() : model.getName(); + } + + /** + * Generate the index doc ID. When a model is the aggregation storage mode, the logicTableName is a part of new ID + * to avoid conflicts. + */ + public String generateDocId(Model model, String originalID) { + if (!isAggregationModel(model)) { + return originalID; + } + return this.generateDocId(model.getName(), originalID); + } + + /** + * Generate the index doc ID. + */ + public String generateDocId(String logicTableName, String originalID) { + return logicTableName + originalID; + } + + /** + * Check the mode of the Model definition. + */ + public boolean isAggregationModel(Model model) { + return StringUtil.isNotBlank(model.getAggregationFunctionName()); + } + + /** + * When a model is the aggregation storage mode, a column named {@link LogicIndicesRegister#LOGIC_TABLE_NAME} would + * be append to the physical index. The value of the column is the original table name in other storages, such as + * the OAL name. + */ + public Map<String, Object> appendLogicTableColumn(Model model, Map<String, Object> columns) { + if (!isAggregationModel(model)) { + return columns; + } + columns.put(LogicIndicesRegister.LOGIC_TABLE_NAME, model.getName()); + return columns; + } + + public static class LogicIndicesRegister { + + /** + * The relations of the logic table and the physical table. + */ + private static final Map<String, String> LOGIC_INDICES_CATALOG = new ConcurrentHashMap<>(); + + public static final String LOGIC_TABLE_NAME = "logic_table"; Review comment: Let's rename this to `metric_name`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
