wu-sheng commented on issue #6441: URL: https://github.com/apache/skywalking/issues/6441#issuecomment-801035130
There are 2 ways 1. Don't focus on the version match mechanism. You could intercept the new construct directly. But as you are sharing the same target class, you need to change the old `HTableInstrumentation` and add a `ConstructorInterceptPoint`. Then, the plugin should be renamed to `hbase-1.x-2.x-plugin`.(documents should be updated too) 2. If you insist to use version match mechanism to create a new plugin called `hbase-2.x-plugin`, then, read `Set up witnessClasses and/or witnessMethods if the instrumentation should be activated in specific versions.` section in the plug dev doc, https://skywalking.apache.org/docs/main/v8.4.0/en/guides/java-plugin-development-guide/. You need to find special class or method to identify the version in the runtime. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
