wu-sheng commented on a change in pull request #6577:
URL: https://github.com/apache/skywalking/pull/6577#discussion_r596946053
##########
File path:
apm-sniffer/apm-sdk-plugin/hbase-1.x-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/hbase/define/HTableInstrumentation.java
##########
@@ -47,11 +47,15 @@
import static net.bytebuddy.matcher.ElementMatchers.named;
import static net.bytebuddy.matcher.ElementMatchers.takesArgument;
import static net.bytebuddy.matcher.ElementMatchers.takesArguments;
+import static
org.apache.skywalking.apm.agent.core.plugin.bytebuddy.ArgumentTypeNameMatch.takesArgumentWithType;
public class HTableInstrumentation extends
ClassInstanceMethodsEnhancePluginDefine {
Review comment:
Add the comments here about
https://github.com/apache/skywalking/pull/6577#discussion_r596931939. We need
to be clear about the naming rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
