wu-sheng commented on a change in pull request #6614:
URL: https://github.com/apache/skywalking/pull/6614#discussion_r600234338



##########
File path: 
apm-sniffer/apm-sdk-plugin/lettuce-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/lettuce/v5/RedisChannelWriterInterceptor.java
##########
@@ -61,6 +71,20 @@ public void beforeMethod(EnhancedInstance objInst, Method 
method, Object[] allAr
         Tags.DB_STATEMENT.set(span, dbStatement.toString());
         SpanLayer.asCache(span);
     }
+    
+    private String getArgsStatement(RedisCommand redisCommand) {

Review comment:
       Take a look at `JDBCPluginConfig#TRACE_SQL_PARAMETERS` to do. Collecting 
parameters costs a lot of resources (CPU/memory).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to