wu-sheng commented on a change in pull request #2643: Rename metric and
indicator to metrics.
URL: https://github.com/apache/skywalking/pull/2643#discussion_r282529287
##########
File path:
oap-server/generate-tool/src/main/java/org/apache/skywalking/oal/tool/parser/Metrics.java
##########
@@ -22,31 +22,30 @@
import com.google.common.reflect.ClassPath;
import java.io.IOException;
import java.util.*;
-import org.apache.skywalking.oap.server.core.analysis.indicator.Indicator;
-import
org.apache.skywalking.oap.server.core.analysis.indicator.annotation.IndicatorFunction;
+import
org.apache.skywalking.oap.server.core.analysis.metrics.annotation.MetricsFunction;
-public class Indicators {
- private static Map<String, Class<? extends Indicator>> REGISTER = new
HashMap<>();
+public class Metrics {
Review comment:
Could we change this to MetricsHolder? I don't want to use full name below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
