[GitHub] [skywalking] wankai123 opened a new pull request #6658: Fix ALS K8SServiceRegistry didn't remove the correct entry

Tue, 30 Mar 2021 19:50:11 -0700 


wankai123 opened a new pull request #6658:
URL: https://github.com/apache/skywalking/pull/6658


   ### Fix <bug description or the bug issue number or bug issue link>
   - [ ] Add a unit test to verify that the fix works.
   - [X] Explain briefly why the bug exists and how to fix it.
   
   The function `removeService` used an incorrect key to remove the entry.
   
![image](https://user-images.githubusercontent.com/16773043/113082133-7bd8ca00-920c-11eb-96ae-9c47c30af239.png)
   
   How to fix it:
   Use `namesapce:name` as the key.
   ```java
       protected void removeService(final V1Service service) {
           ofNullable(service.getMetadata()).ifPresent(
               metadata -> idServiceMap.remove(metadata.getNamespace() + ":" + 
metadata.getName())
           );
       }
   ```
   
   - [ ] If this pull request closes/resolves/fixes an existing issue, replace 
the issue number. Closes #<issue number>.
   - [X] Update the [`CHANGES` 
log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to