kezhenxu94 commented on a change in pull request #6686: URL: https://github.com/apache/skywalking/pull/6686#discussion_r607475215
########## File path: docker/agent/Dockerfile.agent ########## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +ARG BASE_IMAGE='adoptopenjdk/openjdk8:alpine' Review comment: > Will this cause the base image to lose its meaning? Please note, agent image doesn't only host the agent files, and is NOT only for Kubernetes scenarios, can you take a look at https://github.com/apache/skywalking/pull/6686#issuecomment-813799007 and see whether or not it makes sense to you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
