wu-sheng commented on a change in pull request #37:
URL: 
https://github.com/apache/skywalking-satellite/pull/37#discussion_r608469277



##########
File path: docs/en/concepts-and-designs/mmap-queue.md
##########
@@ -41,12 +41,12 @@ goos: darwin
 goarch: amd64
 pkg: github.com/apache/skywalking-satellite/plugins/queue/mmap
 BenchmarkEnqueue
-BenchmarkEnqueue/segmentSize:_128KB_maxInMemSegments:18_message:8KB_queueCapacity:10000
                   10000            106520 ns/op            9888 B/op          
9 allocs/op
-BenchmarkEnqueue/segmentSize:_256KB_maxInMemSegments:10_message:8KB_queueCapacity:10000
                   18536             54331 ns/op            9839 B/op          
9 allocs/op
-BenchmarkEnqueue/segmentSize:_512KB_maxInMemSegments:6_message:8KB_queueCapacity:10000
                    27859             43251 ns/op            9815 B/op          
9 allocs/op
-BenchmarkEnqueue/segmentSize:_256KB_maxInMemSegments:20_message:8KB_queueCapacity:10000
                   23673             45910 ns/op            9839 B/op          
9 allocs/op
-BenchmarkEnqueue/segmentSize:_128KB_maxInMemSegments:10_message:16KB_queueCapacity:10000
                  10000            131686 ns/op           18941 B/op         10 
allocs/op
-BenchmarkEnqueue/segmentSize:_128KB_maxInMemSegments:10_message:8KB_queueCapacity:100000
                  23011             47101 ns/op            9887 B/op          9 
allocs/op
+BenchmarkEnqueue/segmentSize:_128KB_maxInMemSegments:18_message:8KB_queueCapacity:10000
                   27585             43559 ns/op            9889 B/op          
9 allocs/op
+BenchmarkEnqueue/segmentSize:_256KB_maxInMemSegments:10_message:8KB_queueCapacity:10000
                   39326             31773 ns/op            9840 B/op          
9 allocs/op
+BenchmarkEnqueue/segmentSize:_512KB_maxInMemSegments:6_message:8KB_queueCapacity:10000
                    56770             22990 ns/op            9816 B/op          
9 allocs/op
+BenchmarkEnqueue/segmentSize:_256KB_maxInMemSegments:20_message:8KB_queueCapacity:10000
                   43803             29778 ns/op            9840 B/op          
9 allocs/op
+BenchmarkEnqueue/segmentSize:_128KB_maxInMemSegments:10_message:16KB_queueCapacity:10000
                  16870             80576 ns/op           18944 B/op         10 
allocs/op
+BenchmarkEnqueue/segmentSize:_128KB_maxInMemSegments:10_message:8KB_queueCapacity:100000
                  36922             39085 ns/op            9889 B/op          9 
allocs/op

Review comment:
       Whoo, I can see a big improvement.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to