wu-sheng commented on a change in pull request #6715:
URL: https://github.com/apache/skywalking/pull/6715#discussion_r611037522
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/trace/TraceSegment.java
##########
@@ -38,30 +38,15 @@
*/
private String traceSegmentId;
- /**
- * The refs of parent trace segments, except the primary one. For most RPC
call, {@link #refs} contains only one
- * element, but if this segment is a start span of batch process, the
segment faces multi parents, at this moment,
- * we use this {@code #refs} to link them.
- * <p>
- * This field will not be serialized. Keeping this field is only for quick
accessing.
- */
- private List<TraceSegmentRef> refs;
-
/**
* The spans belong to this trace segment. They all have finished. All
active spans are hold and controlled by
* "skywalking-api" module.
*/
private List<AbstractTracingSpan> spans;
- /**
- * The <code>relatedGlobalTraces</code> represent a set of all related
trace. Most time it contains only one
- * element, because only one parent {@link TraceSegment} exists, but, in
batch scenario, the num becomes greater
- * than 1, also meaning multi-parents {@link TraceSegment}. <p> The
difference between
- * <code>relatedGlobalTraces</code> and {@link #refs} is: {@link #refs}
targets this {@link TraceSegment}'s direct
- * parent, <p> and <p> <code>relatedGlobalTraces</code> targets this
{@link TraceSegment}'s related call chain, a
- * call chain contains multi {@link TraceSegment}s, only using {@link
#refs} is not enough for analysis and ui.
- */
- private DistributedTraceIds relatedGlobalTraces;
+ private TraceSegmentRef traceSegmentRef;
Review comment:
Why rename? And put a duplicated `traceSegment` in the name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
