wu-sheng commented on a change in pull request #6715:
URL: https://github.com/apache/skywalking/pull/6715#discussion_r611623569
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/trace/TraceSegment.java
##########
@@ -121,16 +116,19 @@ public String getTraceSegmentId() {
return traceSegmentId;
}
- public boolean hasRef() {
- return !(refs == null || refs.size() == 0);
- }
-
+ /**
+ * For testing use only.
+ */
public List<TraceSegmentRef> getRefs() {
Review comment:
Why this API doesn't change? You are optimizing the implementation, you
should clear the legacy codes once for all. Otherwise, people are going to be
confused when reading this next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
