klboke commented on a change in pull request #6763:
URL: https://github.com/apache/skywalking/pull/6763#discussion_r614706534
##########
File path:
oap-server/server-storage-plugin/storage-zipkin-elasticsearch7-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/zipkin/elasticsearch/ZipkinTraceQueryEs7DAO.java
##########
@@ -211,9 +214,14 @@ public TraceBrief queryBasicTraces(long startSecondTB,
});
if (StringUtil.isNotEmpty(serviceId)) {
final IDManager.ServiceID.ServiceIDDefinition
serviceIDDefinition = IDManager.ServiceID.analysisId(
- serviceId);
+ serviceId);
swSpan.setServiceCode(serviceIDDefinition.getName());
}
+ if (StringUtil.isNotEmpty(serviceInstanceId)) {
Review comment:
What I mean is that GraphQL also defines that the serviceCode cannot be
empty, but it also makes null processing when processing the serviceId. I am
not very clear about the reason, so I refer to the processing logic of the
serviceId
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
