Fine0830 commented on pull request #474:
URL: 
https://github.com/apache/skywalking-rocketbot-ui/pull/474#issuecomment-822175843


   I have checked this and have found the following problems
   
   1. The component style of `TraceSearch` is wrong.
   2. When we select a service, the logic should only fetch endpoints and 
instance of this service, rather than fetching services,  endpoints and 
instance of this service, traces.
   3. Set a default value for endpoints name. Should we add `All` in endpoints 
selector? @wu-sheng 
   
![test](https://user-images.githubusercontent.com/20871783/115185434-6a4f5780-a112-11eb-852b-76e22d0d190e.png)
   
   Please fix those. Thank you for your contribution @horber.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to