wayilau commented on a change in pull request #2710: Remove the ex which not
thrown. & add logs for interceptor.
URL: https://github.com/apache/skywalking/pull/2710#discussion_r285348174
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/loader/InterceptorInstanceLoader.java
##########
@@ -80,6 +78,9 @@
}
if (inst != null) {
INSTANCE_CACHE.put(instanceKey, inst);
+ logger.debug("interceptor instance is created for class '{}',
instanceKey is: {}", className, instanceKey);
Review comment:
> What is the purpose of adding a log for this? I think even most agent
developer doesn't care much about this.
I think it provides a log for developer who wants to know more detail about
what the instance status is. I will remove the logger variable if we don'it
need it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
