wu-sheng commented on a change in pull request #2710: Remove the ex which not
thrown. & add logs for interceptor.
URL: https://github.com/apache/skywalking/pull/2710#discussion_r285413201
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/loader/InterceptorInstanceLoader.java
##########
@@ -80,6 +78,9 @@
}
if (inst != null) {
INSTANCE_CACHE.put(instanceKey, inst);
+ logger.debug("interceptor instance is created for class '{}',
instanceKey is: {}", className, instanceKey);
Review comment:
I don't know whether we need that. I am OK to discuss. Right now, there are
only @ascrutae @candyleer and I have experiences and developed core codes. The
opinion of mine is, most people even don't understand what the agent really
does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
