wu-sheng commented on a change in pull request #474:
URL:
https://github.com/apache/skywalking-rocketbot-ui/pull/474#discussion_r616703150
##########
File path: src/views/components/trace/trace-search.vue
##########
@@ -132,16 +141,12 @@ limitations under the License. -->
private maxTraceDuration: string =
localStorage.getItem('maxTraceDuration') || '';
private minTraceDuration: string =
localStorage.getItem('minTraceDuration') || '';
private instance: Option = { label: 'All', key: '' };
- private endpointName: string = localStorage.getItem('endpointName') || '';
+ private endpoint: Option = { label: 'All', key: '' };
private traceId: string = localStorage.getItem('traceId') || '';
private traceState: Option = { label: 'All', key: 'ALL' };
private tags: string = '';
private tagsList: string[] = [];
-
private created() {
- this.endpointName = this.$route.query.endpointname
- ? this.$route.query.endpointname.toString()
- : this.endpointName;
Review comment:
@Fine0830 Please confirm, after this change, whether endpoint id is not
required in the query? If so, I am willing to remove it from query protocol if
the CLI side is fine with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
