wu-sheng commented on pull request #6794:
URL: https://github.com/apache/skywalking/pull/6794#issuecomment-824415599


   > > The UT could only test webhook is working, but we have no chance to 
verify whether WeLink actually works.
   > > @kezhenxu94 Any suggestion? Should we merge this blindly?
   > 
   > When alarm rules are triggered, as long as the webhook request is sent 
from SkyWalking side I think we’re done, testing whether WeLink works or not 
after receiving the webhook is beyond our responsibility.
   
   OK, agree. Let me document here in case bugs showing up in the future.
   
   **SkyWalking community considers this harmless and merges this as a part of 
the codebase. We have no committer tested. We will not respond to a bug report 
or enhancement requirement. We could forward this kind of report to @YunfengGao 
or wait for other volunteers to fix it or support it.**
   
   @apache/skywalking-committers Any objection, please let me know. I will wait 
2 days at least.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to