[GitHub] [skywalking] wu-sheng commented on issue #2723: skywalking agent support label select

[GitBox]

wu-sheng commented on issue #2723: skywalking agent support label select
URL: https://github.com/apache/skywalking/issues/2723#issuecomment-494218202
 
 
   Do you want to search service name by label(s) from UI?
   
   Right now, in the register protocol, we have tags and properties
   ```grpc
   message Service {
       string serviceName = 1;
       repeated KeyStringValuePair tags = 3;
       repeated KeyStringValuePair properties = 4;
   }
   
   message ServiceInstance {
       int32 serviceId = 1;
       string instanceUUID = 2;
       int64 time = 3;
       repeated KeyStringValuePair tags = 4;
       repeated KeyStringValuePair properties = 5;
   }
   ```
   
   What do you mean by label? And if you set labels(s) on instance differently, 
what is the expected result?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services