[GitHub] [skywalking] darcydai edited a comment on pull request #6783: fix a bug that spring-mvc set an error endpoint name

Thu, 22 Apr 2021 08:48:51 -0700 


darcydai edited a comment on pull request #6783:
URL: https://github.com/apache/skywalking/pull/6783#issuecomment-824954672


   I found a new bug when i coding the scenarios test for the spring MVC 
plugin. i have fixed in last commit
    
`org.apache.skywalking.apm.plugin.spring.mvc.commons.interceptor.RequestMappingMethodInterceptor#getRequestURL`
   
   
![image](https://user-images.githubusercontent.com/20854418/115739073-3305d280-a3c0-11eb-92cd-3777b44a6ceb.png)
   
   1. the annotation RequestMapping with the value[value()] array length equals 
zero represents an empty string in the spring MVC concept.
   
![image](https://user-images.githubusercontent.com/20854418/115740608-917f8080-a3c1-11eb-845a-7668e0d39993.png)
   
   
   
   2. RequestMapping in spring mvc 3.x and 4.1  has no the path method 
[path()], if RequestMapping with  with the value[value()] array length equals 
zore in spring mvc 3 will cause no such method error;
   
![image](https://user-images.githubusercontent.com/20854418/115740421-6006b500-a3c1-11eb-95c1-19a6b86a6f93.png)
   
   
![image](https://user-images.githubusercontent.com/20854418/115743703-7bbf8a80-a3c4-11eb-9260-e14064dba9eb.png)
   
   
   
   3. because of AliasFor annotation, no need to call path(), I have tested
   
![image](https://user-images.githubusercontent.com/20854418/115740763-bbd13e00-a3c1-11eb-8830-22deb853d5e6.png)
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to