wu-sheng commented on a change in pull request #56:
URL:
https://github.com/apache/skywalking-query-protocol/pull/56#discussion_r619605814
##########
File path: alarm.graphqls
##########
@@ -24,14 +24,20 @@ type AlarmMessage {
scope: Scope
id: ID!
message: String!
+ tags: [KeyValue!]!
}
type Alarms {
msgs: [AlarmMessage!]!
total: Int!
}
+input AlarmTag {
+ key: String!
+ value: String
+}
+
extend type Query {
getAlarmTrend(duration: Duration!): AlarmTrend!
- getAlarm(duration: Duration!, scope: Scope, keyword: String, paging:
Pagination!): Alarms
+ getAlarm(duration: Duration!, scope: Scope, keyword: String, paging:
Pagination!, tags: [AlarmTag]): Alarms
Review comment:
The old tag discussion is only related to notification, it makes sense
to add this on about native/default UI. But still, the process is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
