hanahmily commented on a change in pull request #8: helm charts URL: https://github.com/apache/skywalking-kubernetes/pull/8#discussion_r286544254
########## File path: helm/charts/6/6.0.0-GA/skywalking/templates/elasticsearch/elasticsearch-statefulset.yml ########## @@ -0,0 +1,123 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +apiVersion: apps/v1 +kind: StatefulSet +metadata: + name: {{ template "skywalking.fullname" . }}-elasticsearch + labels: Review comment: > Except for namespace, other Changes requested have been modified. > > About namespace ,I have two ways. > > * now charts > * add the namespace configuration to each file and maintain this configuration with values.yaml > `helm install skywalking --set=""` > I recommend using the first method, I refer to helm/charts repo. > > Help review again , thanks You are right. Most of the charts in helm repo don't contain `namespace` in their artifacts. I used to set it but it seems not the best practice. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
