wu-sheng commented on pull request #263:
URL: 
https://github.com/apache/skywalking-website/pull/263#issuecomment-827286235


   > > I think the data is still incorrect. We have 466 for all repositories, 
and over 368 for one repository. But the graph shows less than 350, what is the 
gap?
   > 
   > Sorry the wrong image got cached in CDN, I tried to refresh the cache but 
it seems not working for all edge servers. We might need to wait for some time 
(~1 day I guess) to let it back to the correct one. But anyway the correct one 
would look like this.
   > 
https://www.apiseven.com/en/contributor-graph?chart=contributorOverTime&repo=apache/skywalking&merge=true
   > 
![image](https://user-images.githubusercontent.com/34589752/116177521-7b1d5000-a746-11eb-85b4-5c3747a29bdb.png)
   > 
   > But from what we get, there are 402 contributors from skywalking related 
repos, and 343 contributors directly to `apache/skywalking`. We get the data by 
fetching Github API to process all commits, so the results would be more 
similar to what shows on the Github Repo page.
   > 
![image](https://user-images.githubusercontent.com/34589752/116178744-ba4ca080-a748-11eb-9dae-23bb790f9031.png)
   > As we noticed, one benefit of using Github API rather than directly 
process git log, is we could avoid the situation when one account using several 
email addresses to commit so the result would be higher than the real value. I 
guess that could be the reason causing the gap.
   > 
   > I could provide some raw data for reference.
   > 
   > **Contributor Number of Each Repo**
   > 
   > Name       Num
   > apache/skywalking  343
   > apache/skywalking-rocketbot-ui     58
   > apache/skywalking-website  53
   > apache/skywalking-ui       19
   > apache/skywalking-data-collect-protocol    18
   > apache/skywalking-nginx-lua        17
   > apache/skywalking-python   15
   > apache/skywalking-kubernetes       13
   > apache/skywalking-query-protocol   13
   > apache/skywalking-agent-test-tool  11
   > apache/skywalking-cli      9
   > apache/skywalking-docker   9
   > apache/skywalking-client-js        8
   > apache/skywalking-satellite        8
   > apache/skywalking-eyes     5
   > apache/skywalking-infra-e2e        5
   > apache/skywalking-nodejs   5
   > apache/skywalking-swck     5
   > apache/skywalking-kong     4
   > apache/skywalking-banyandb 3
   > apache/skywalking-goapi    3
   > apache/skywalking-kubernetes-event-exporter        3
   > apache/skywalking-oal-tool 2
   > apache/skywalking-rust     1
   
   We are aware of the gap(dozens actually) between GitHub API and git log. Our 
@Jtrust set up the data, and according to our discussion, we want to count all 
people in. The missing people are from the very beginning of SkyWalking, we 
used to accept PR but not use `squash and merge`. So once they didn't set their 
git mailbox as same as GitHub's setting, we lost them in the statistic.
   But still, they are existing in the contributor group, and we want to count 
them in.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to