ascrutae commented on a change in pull request #6783:
URL: https://github.com/apache/skywalking/pull/6783#discussion_r621293361



##########
File path: test/plugin/scenarios/spring-3.0.x-scenario/config/expectedData.yaml
##########
@@ -14,52 +14,130 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 segmentItems:
-- serviceName: spring-3.0.x-scenario
-  segmentSize: ge 2
-  segments:
-  - segmentId: not null
-    spans:
-    - operationName: /healthCheck
-      operationId: 0
-      parentSpanId: -1
-      spanId: 0
-      spanLayer: Http
-      startTime: nq 0
-      endTime: nq 0
-      componentId: 14
-      isError: false
-      spanType: Entry
-      peer: ''
-      tags:
-      - {key: url, value: 
'http://localhost:8080/spring-3.0.x-scenario/healthCheck'}
-      - {key: http.method, value: HEAD}
-      skipAnalysis: 'false'
-  - segmentId: not null
-    spans:
-    - {operationName: 
test.apache.skywalking.apm.testcase.spring3.component.TestComponentBean.componentMethod,
-      operationId: 0, parentSpanId: 1, spanId: 2, spanLayer: Unknown, 
startTime: nq
-        0, endTime: nq 0, componentId: 93, isError: false, spanType: Local, 
peer: '',
-      skipAnalysis: 'false'}
-    - {operationName: 
test.apache.skywalking.apm.testcase.spring3.dao.TestRepositoryBean.doSomeStuff,
-      operationId: 0, parentSpanId: 1, spanId: 3, spanLayer: Unknown, 
startTime: nq
-        0, endTime: nq 0, componentId: 93, isError: false, spanType: Local, 
peer: '',
-      skipAnalysis: 'false'}
-    - {operationName: 
test.apache.skywalking.apm.testcase.spring3.service.TestServiceBean.doSomeBusiness,
-      operationId: 0, parentSpanId: 0, spanId: 1, spanLayer: Unknown, 
startTime: nq
-        0, endTime: nq 0, componentId: 93, isError: false, spanType: Local, 
peer: '',
-      skipAnalysis: 'false'}
-    - operationName: /case/spring3
-      operationId: 0
-      parentSpanId: -1
-      spanId: 0
-      spanLayer: Http
-      startTime: nq 0
-      endTime: nq 0
-      componentId: 14
-      isError: false
-      spanType: Entry
-      peer: ''
-      tags:
-      - {key: url, value: 
'http://localhost:8080/spring-3.0.x-scenario/case/spring3'}
-      - {key: http.method, value: GET}
-      skipAnalysis: 'false'
+  - serviceName: spring-3.0.x-scenario
+    segmentSize: ge 4
+    segments:
+      - segmentId: not null
+        spans:
+          - operationName: /healthCheck
+            operationId: 0
+            parentSpanId: -1
+            spanId: 0
+            spanLayer: Http
+            startTime: nq 0
+            endTime: nq 0
+            componentId: 14
+            isError: false
+            spanType: Entry
+            peer: ''
+            skipAnalysis: false
+            tags:
+              - {key: url, value: 
'http://localhost:8080/spring-3.0.x-scenario/healthCheck'}
+              - {key: http.method, value: HEAD}
+      - segmentId: not null
+        spans:
+          - operationName: /impl/requestmapping
+            operationId: 0
+            parentSpanId: -1
+            spanId: 0
+            spanLayer: Http
+            startTime: nq 0
+            endTime: nq 0
+            componentId: 14
+            isError: false
+            spanType: Entry
+            peer: ''
+            skipAnalysis: false
+            tags:
+              - {key: url, value: 
'http://localhost:8080/spring-3.0.x-scenario//impl/requestmapping'}
+              - {key: http.method, value: GET}
+            refs:
+              - {parentEndpoint: /case/spring3, networkAddress: 
'localhost:8080', refType: CrossProcess,
+                 parentSpanId: 5, parentTraceSegmentId: not null,
+                 parentServiceInstance: not null, parentService: 
spring-3.0.x-scenario,
+                 traceId: not null}
+      - segmentId: not null
+        spans:
+          - operationName: '{GET}/impl/restmapping'
+            operationId: 0
+            parentSpanId: -1
+            spanId: 0
+            spanLayer: Http
+            startTime: nq 0
+            endTime: nq 0
+            componentId: 14
+            isError: false
+            spanType: Entry
+            peer: ''
+            skipAnalysis: false
+            tags:
+              - {key: url, value: 
'http://localhost:8080/spring-3.0.x-scenario//impl/restmapping'}
+              - {key: http.method, value: GET}
+            refs:
+              - {parentEndpoint: /case/spring3, networkAddress: 
'localhost:8080', refType: CrossProcess,
+                 parentSpanId: 6, parentTraceSegmentId: not null,
+                 parentServiceInstance: not null, parentService: 
spring-3.0.x-scenario,
+                 traceId: not null}
+      - segmentId: not null
+        spans:
+          - {operationName: 
test.apache.skywalking.apm.testcase.spring3.component.TestComponentBean.componentMethod,
+             operationId: 0, parentSpanId: 1, spanId: 2, spanLayer: Unknown, 
startTime: nq 0,
+             endTime: nq 0, componentId: 93, isError: false, spanType: Local, 
peer: '',
+             skipAnalysis: false}
+          - {operationName: 
test.apache.skywalking.apm.testcase.spring3.dao.TestRepositoryBean.doSomeStuff,
+             operationId: 0, parentSpanId: 1, spanId: 3, spanLayer: Unknown, 
startTime: nq 0,
+             endTime: nq 0, componentId: 93, isError: false, spanType: Local, 
peer: '',
+             skipAnalysis: false}
+          - {operationName: 
test.apache.skywalking.apm.testcase.spring3.service.TestServiceBean.doSomeBusiness,
+             operationId: 0, parentSpanId: 0, spanId: 1, spanLayer: Unknown, 
startTime: nq 0,
+             endTime: nq 0, componentId: 93, isError: false, spanType: Local, 
peer: '',
+             skipAnalysis: false}
+          - operationName: /spring-3.0.x-scenario//impl/requestmapping
+            operationId: 0
+            parentSpanId: 4
+            spanId: 5
+            spanLayer: Http
+            startTime: nq 0
+            endTime: nq 0
+            componentId: 13
+            isError: false
+            spanType: Exit
+            peer: localhost:8080
+            skipAnalysis: false
+            tags:
+              - {key: url, value: 
'http://localhost:8080/spring-3.0.x-scenario//impl/requestmapping'}

Review comment:
       Same as above




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to