darcydai opened a new pull request #6894: URL: https://github.com/apache/skywalking/pull/6894
Hi all, I open this PR aims to confirm that I am doing the right thing. there is so much work that needs to do, like unit test case, scenario test case,optimize the spring MVC match logic In a distributed system, hundreds of services in the skywalking cluster, group endpoint name in the server by regex pattern configuration are very difficult for skywalking cluster maintainer, even impossible. using a group mechanism in the agent may be better. for example, the servlet container has no path variable concept, and spring mvc achieves this feature. if a request with a path variable is rejected by a servlet filter (like authenticate filter),the endpoint can not reset by spring mvc interceptor. it will cause endpoint options in skywalking UI very hard to use (endpoint traffic), more cost for metric aggregation(especial endpoint 2 endpoint relations ), and more alarm window for alarm module (even oom in OAP server). we can get the path mapping info when controller creating, and try to rename endpoint(use same logic like spring MVC path match) when sending to skywalking backend service. now I made the feature in an optional plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
