zhaoyuguang commented on issue #2750: Logback support AsyncAppender print tid
URL: https://github.com/apache/skywalking/pull/2750#issuecomment-495615886
 
 
   > Does end user need any document to make this work? Or this is totally 
automatically?
   
   There is a difficulty here, I need help! @wu-sheng @acurtain 
   
![image](https://user-images.githubusercontent.com/10150229/58328997-1a07e600-7e66-11e9-8f45-819b8714b4df.png)
   
   ```
   AsyncAppender extends AsyncAppenderBase<ILoggingEvent>
   AsyncAppenderBase::put method allArgument is ILoggingEvent
   ILoggingEvent has at least 3 implementations in my project
   But I only enhanced the LoggingEvent;
   Because when I interrupted, I found out that the real message is it;
   Because I am not very familiar with logback;
   So this code is written like this?
   Add more instanceof?
   Still enhancing ILOggingEvent?
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to