wu-sheng commented on a change in pull request #6913:
URL: https://github.com/apache/skywalking/pull/6913#discussion_r628711243
##########
File path:
apm-sniffer/optional-plugins/mybatis-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/mybatis/SqlSessionOperationInterceptor.java
##########
@@ -40,7 +41,8 @@ public void beforeMethod(EnhancedInstance objInst, Method
method, Object[] allAr
if (ContextManager.isActive()) {
lastSpan = ContextManager.activeSpan();
}
- if (lastSpan == null || lastSpan.getComponentId() !=
ComponentsDefine.MYBATIS.getId()) {
+ boolean isMyBatisEntryMethod = !(lastSpan instanceof NoopSpan) &&
(lastSpan == null || lastSpan.getComponentId() !=
ComponentsDefine.MYBATIS.getId());
Review comment:
This check is actually costing resources, much more than intercepting
multiple methods. Because intercepting different methods doesn't happen in the
runtime, so, no latency cost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
