wu-sheng commented on issue #6915: URL: https://github.com/apache/skywalking/issues/6915#issuecomment-836438202
Generally agree to change `AbstractClassEnhancePluginDefine`. I want to add a layer on the top of `AbstractClassEnhancePluginDefine`, which should implement `getInstanceMethodsInterceptV2Points` and `getStaticMethodsInterceptV2Points`. To reduce code change, we could still call this new layer as `AbstractClassEnhancePluginDefine`. and rename the current `AbstractClassEnhancePluginDefine` as `AbstractClassEnhancePluginCoreDefine`. Also, we need a new `AbstractClassEnhancePluginDefineV2` Notice, I did a naming style change, `getInstanceMethodsInterceptPointV2s` to `getInstanceMethodsInterceptV2Points` > For performance, I rather copy `InstMethodsInterV2` than add any condition in `InstMethodsInter#intercept(...)`. Yes. We need to copy them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
